Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PNG parsing performance. #20908

Merged
merged 1 commit into from Jun 10, 2023
Merged

Conversation

RoosterDragon
Copy link
Member

Switch on the filter once per row rather than once per byte. This allows each row to be processed with a much tighter loop.


This makes the PNG parser 1.8x faster. When loading the RA mod it reduces time spent parsing PNGs from 4.4% to 2.4%.

Switch on the filter once per row rather than once per byte. This allows each row to be processed with a much tighter loop.
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look sensible, and doesn't obviously break anything that I could see in the loadscreens/main menu/map previews.

@Mailaender
Copy link
Member

@OpenHV load time reduction

this: 2769 ± 28 ms
bleed: 2843 ± 4 ms

@Mailaender Mailaender merged commit 06df75f into OpenRA:bleed Jun 10, 2023
3 checks passed
@RoosterDragon RoosterDragon deleted the png-perf branch June 10, 2023 14:20
@Mailaender
Copy link
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants