Include Linux DE in OS sysinfo string. #20917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Squeezing everything into one string won't make evaluations easier. |
abcdefg30
reviewed
Jun 14, 2023
| if (!string.IsNullOrEmpty(sessionType)) | ||
| sessionType = $" ({sessionType})"; | ||
|
|
||
| string suffix; |
There was a problem hiding this comment.
Suggested change
| string suffix; | |
| var suffix = string.Empty; |
and then drop the else case.
There was a problem hiding this comment.
I think the current setup makes more sense. (Why assign values which will get overwritten anyway?)
|
Looks fine from my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the current desktop environment alongside the OS and display server on Linux. This can inform discussions about whether / how much effort to put into supporting a given DE is worthwhile.
From the Arch wiki: