Minelaying: added extensibility points + move to Common #20933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Mailaender
previously approved these changes
Jul 1, 2023
abcdefg30
reviewed
Jul 3, 2023
michaeldgg2
force-pushed
the
Minelaying-Extensibility-Points
branch
from
4e8a7c3
to
2910186
Compare
Provides two callbacks using INotifyMineLaying interface: MineLaying (just before laying a mine), MineLaid after mine actor has been created (in FrameEndTask)
abcdefg30
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds extensibility points to
LayMinesactivity using two callbacks defined byINotifyMineLayinginterface:MineLaying(just before laying a mine)MineLaidafter mine actor has been created (inFrameEndTask)Plus the PR moves Minelaying-related classes to
OpenRA.Mods.Commonand makesMine-related classes public.