MiniYaml performance #20956
Merged
MiniYaml performance #20956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoosterDragon
force-pushed
the
mini-yaml-perf
branch
6 times, most recently
from
3d30930
to
05e2b8a
Compare
PunkPun
reviewed
Jul 9, 2023
abcdefg30
reviewed
Jul 9, 2023
Use an ImmutableDictionary to avoid having to clone the inheritance tree in ResolveInherits. This avoids a lot of dictionary clones.
Moving the key duplication check allows a redundant check on top-level nodes to be avoided. Add tests to ensure key checks are functioning as expected.
- Track plain keys in a set, to avoid quadratic searches for plain node keys. - Avoid the Concat iterator by looping twice instead.
- Seal the classes, and make SourceLocation a readonly struct. - In ToDictionary, use TryAdd to avoid a try-catch. - In Merge, use ToList to ensure sources is only enumerated once.
Use CollectionsMarshal to hold a ref to the dictionary entry. When the value needs to be added this allows us to set the value directly into it without having to locate the entry a second time.
RoosterDragon
force-pushed
the
mini-yaml-perf
branch
from
05e2b8a
to
d0b27af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of performance improvements to MiniYaml, see individual commits for details.
When loading the RA mod, provides a modest improvement by reducing time spent in MiniYaml.FromLines from 2.8% to 2.4%.