Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More minelaying improvements #20963

Merged
merged 2 commits into from
Jul 28, 2023
Merged

More minelaying improvements #20963

merged 2 commits into from
Jul 28, 2023

Conversation

michaeldgg2
Copy link
Contributor

@michaeldgg2 michaeldgg2 commented Jul 14, 2023 •
edited
Loading

Third round of improvements for Minelayer:

  • LayMines renders minefield cells only if the minefield has more than 1 cell
  • GrantConditionOnMinelaying trait for making a condition that is granted when minelayer is laying a mine

@michaeldgg2 michaeldgg2 marked this pull request as ready for review July 20, 2023 14:45
@PunkPun
Copy link
Member

PunkPun commented Jul 25, 2023

I don't mind the addition of WithDeployMineAnimation

@michaeldgg2 michaeldgg2 force-pushed the Minelaying-Improvements2 branch 2 times, most recently from 05e0aa3 to bd51bfb Compare July 26, 2023 15:56
abcdefg30
abcdefg30 previously approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but code changes lgtm.

@PunkPun
Copy link
Member

PunkPun commented Jul 27, 2023

I'm thinking, couldn't it be better to just have a GrantConditionOnMinelaying trait? Then you could use all the other cool visuals and not be limited to just changing the actors SpriteBody

@michaeldgg2
Copy link
Contributor Author

michaeldgg2 commented Jul 27, 2023 •
edited
Loading

So I made that GrantConditionOnMinelaying trait. Do you want me to remove WithDeployMineAnimation trait from PR? We're OK with that, reimplementing the behavior using GrantConditionOnMinelaying is easy.

openra_minelayer_grantcondition_idleoverlay

@PunkPun
Copy link
Member

PunkPun commented Jul 27, 2023

Yeah, the trait can be removed. It's redundant

@michaeldgg2
Added GrantConditionOnMinelaying trait
2c12a47 
Uses INotifyMineLaying callbacks
PunkPun
PunkPun approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit d907192 into OpenRA:bleed Jul 28, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Jul 28, 2023

Changelog

@michaeldgg2 michaeldgg2 deleted the Minelaying-Improvements2 branch September 20, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PunkPun PunkPun PunkPun approved these changes

@abcdefg30 abcdefg30 abcdefg30 left review comments

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaeldgg2 @PunkPun @abcdefg30