Fix AutoTarget ignoring frozen actor bot targeting hack #20978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour mismatch can cause an AI unit which has attack range longer that vision range to freeze in place. The check added in db2fded made the bug less common, but as #20257 was merged the checks now hide the bug in way fewer cases
The fix is to mirror these checks to AutoTarget
OpenRA/OpenRA.Mods.Common/TargetExtensions.cs
Lines 42 to 57 in c093e7c