Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text fix, minor polish to Controlled Burn #20999

Merged
merged 1 commit into from Aug 28, 2023

Conversation

JovialFeline
Copy link
Contributor

These are some changes prompted by feedback from Henskelion on the discord. The main aim was a timely translation fix, so the changes are light.


Fixed some text that was left untranslated after the strings were extracted.

ControlledBurn-Text-1

Once all structures in the main base (aside from sarin plants) are killed or captured, USSR's units will hunt to speed up the ending.

  • This is not original behavior for the map, but this or fire sales are common with "Destroy all X" objectives.
  • Idle harvesters won't need to be killed to "Destroy the enemy compound." I figure that lines up with the earlier BadGuy change.

The Allies' signal flare is announced, as in the original.

Fixed the linter's complaint about GroundWavesDelays being used as a table and integer.

@PunkPun PunkPun added this to the Next Release milestone Aug 10, 2023
PunkPun
PunkPun previously approved these changes Aug 10, 2023
@JovialFeline
Copy link
Contributor Author

  • Patrolling USSR units should now act on the finishing hunt immediately.
  • Harvesters removed as required kills through map rules rather than the Lua script. This affects the player too, but a handful of trucks are unlikely to win on their own.
  • Closed a PR by mistake with an empty push, again.

@JovialFeline
Copy link
Contributor Author

The finishing hunt now uses IdleHunt instead of a Hunt order.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mailaender Mailaender merged commit 7bd4b45 into OpenRA:bleed Aug 28, 2023
3 checks passed
@Mailaender
Copy link
Member

8b3e7be

@Mailaender
Copy link
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants