Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a bogus CanDeploy check from order resolving for charge deploys #21001

Merged
merged 1 commit into from Aug 11, 2023

Conversation

abcdefg30
Copy link
Member

Fixes an oversight from #20824. The deploy state cannot be checked at this time for (queued) orders. To reproduce simply let a Saboteur run out of charge, order the unit to move and immediately queue a deploy. On bleed it will not deploy when finishing the move activity. With this PR it will.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit e1940ee into OpenRA:bleed Aug 11, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Aug 11, 2023

Changelog

@abcdefg30 abcdefg30 deleted the fixQueuedChargeDeploy branch August 11, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants