Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically order units away when trying to deploy transform #21016

Merged
merged 1 commit into from Aug 26, 2023
Merged

Automatically order units away when trying to deploy transform #21016

merged 1 commit into from Aug 26, 2023

Conversation

Mailaender
Copy link
Member

This expands on #9239.

@Mailaender Mailaender mentioned this pull request Aug 22, 2023
Closed
PunkPun
PunkPun reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original function is basically identical, and it would be identical if one were to make them static. Could we perhaps reuse the logic? They are in the same scope

OpenRA.Mods.Common/Traits/Transforms.cs Outdated Show resolved Hide resolved
@Mailaender Mailaender force-pushed the auto-unblock-transform branch 2 times, most recently from d7b9fa7 to 0e5ab91 Compare August 26, 2023 10:53
@PunkPun PunkPun merged commit bf64339 into OpenRA:bleed Aug 26, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Aug 26, 2023

Changelog

@Mailaender Mailaender deleted the auto-unblock-transform branch August 26, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoosterDragon RoosterDragon RoosterDragon approved these changes

@PunkPun PunkPun PunkPun approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mailaender @PunkPun @RoosterDragon