Automatically order units away when trying to deploy transform - #21016
Merged
Conversation
RoosterDragon
approved these changes
Aug 22, 2023
PunkPun
reviewed
Aug 23, 2023
PunkPun
left a comment
PunkPun
left a comment
Member
There was a problem hiding this comment.
The original function is basically identical, and it would be identical if one were to make them static. Could we perhaps reuse the logic? They are in the same scope
Mailaender
force-pushed
the
auto-unblock-transform
branch
from
August 25, 2023 19:16
a49c48f to
20a0d97
Compare
Mailaender
force-pushed
the
auto-unblock-transform
branch
from
August 25, 2023 19:25
20a0d97 to
45b914a
Compare
PunkPun
reviewed
Aug 26, 2023
Mailaender
force-pushed
the
auto-unblock-transform
branch
2 times, most recently
from
August 26, 2023 10:53
d7b9fa7 to
0e5ab91
Compare
PunkPun
force-pushed
the
auto-unblock-transform
branch
from
August 26, 2023 17:36
0e5ab91 to
b89f641
Compare
PunkPun
approved these changes
Aug 26, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands on #9239.