Turn ModelRenderer and VoxelCache into traits #21066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvilvapre
reviewed
Sep 19, 2023
| public void EndFrame() | ||
| { | ||
| foreach (var r in renderers) | ||
| r.EndFrame(); |
There was a problem hiding this comment.
Questions that come to mind.
Renderers would be independant of each other? No cross refences or shared state? Would some IRenderables references multiple renderers?
I see you pass the renderable when creating the IRenderable.
So this would mean the renderes could be active/called in any order.
This only ensures the order in which begin and end frame is called.
Might be an option to put MapEditor DebugRenderables in seperate renderer. But may not have much added value.
There was a problem hiding this comment.
This will get much more polished once we turn SpriteRenderers into a trait. This current solution is as minimal as possible
PunkPun
force-pushed
the
ModelRenderer
branch
3 times, most recently
from
f06a73e
to
2c901dd
Compare
PunkPun
changed the title
Merged
PunkPun
force-pushed
the
ModelRenderer
branch
2 times, most recently
from
20d65c2
to
e11a4db
Compare
|
You can remove |
PunkPun
force-pushed
the
ModelRenderer
branch
from
e11a4db
to
3c8fc61
Compare
|
Good catch, removed |
Mailaender
approved these changes
Sep 23, 2023
Mailaender
reviewed
Oct 8, 2023
Mailaender
reviewed
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer will
Renderer,WorldandModContentneed to acknowledge the existence of voxels. This cleans up the engine, but not fully. Next step would be better abstracting voxels from asset browser