ReinforceWithTransport: no hardcoded land facing#21089
Merged
Merged
Conversation
Member
|
Why does it need to be changed? Wouldn't be inconsistent if initial facing field was ignored? |
Contributor
Author
|
No, initial facing should be used in creation of the actor while in this function use it as facing on landing! This makes aircraft turns to its initial facing and land, looks very weird from normal landing behavior. |
PunkPun
reviewed
Oct 9, 2023
PunkPun
left a comment
PunkPun
left a comment
Member
There was a problem hiding this comment.
In the Land activity it's also used as a default. I suppose defining it here is pointless then
PunkPun
approved these changes
Oct 9, 2023
Member
|
I tested it and it seemed to work correctly. Though I missed a comment... I tracked it down to #16509 (comment). It doesn't feel critical but probably something we should address |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.