Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small FireWarheads tweaks #21096

Merged
merged 2 commits into from Oct 9, 2023
Merged

Small FireWarheads tweaks #21096

merged 2 commits into from Oct 9, 2023

Conversation

michaeldgg2
Copy link
Contributor

Small tweaks for FireWarheads trait:

  • FireWarheads unnecessarily depends on IMove making it difficult to use for non-Mobile/Aircraft actors
  • playing weapon's report sound in FrameEndTask is not necessary

@michaeldgg2 michaeldgg2 mentioned this pull request Oct 7, 2023
Closed
PunkPun
PunkPun approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit 9ae26f2 into OpenRA:bleed Oct 9, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Oct 9, 2023

Changelog

@michaeldgg2 michaeldgg2 deleted the FireWarheads-tweaks branch October 28, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote left review comments

@PunkPun PunkPun PunkPun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaeldgg2 @PunkPun @pchote