Skip to content

Small FireWarheads tweaks#21096

Merged
PunkPun merged 2 commits into
OpenRA:bleedfrom
michaeldgg2:FireWarheads-tweaks
Oct 9, 2023
Merged

Small FireWarheads tweaks#21096
PunkPun merged 2 commits into
OpenRA:bleedfrom
michaeldgg2:FireWarheads-tweaks

Conversation

@michaeldgg2

Copy link
Copy Markdown
Contributor

Small tweaks for FireWarheads trait:

  • FireWarheads unnecessarily depends on IMove making it difficult to use for non-Mobile/Aircraft actors
  • playing weapon's report sound in FrameEndTask is not necessary

Comment thread OpenRA.Mods.Common/Traits/FireWarheads.cs Outdated

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit 9ae26f2 into OpenRA:bleed Oct 9, 2023
@PunkPun

PunkPun commented Oct 9, 2023

Copy link
Copy Markdown
Member

Changelog

@michaeldgg2 michaeldgg2 deleted the FireWarheads-tweaks branch October 28, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants