Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing deprecation notices to Lua docs #21110

Merged
merged 1 commit into from Oct 16, 2023
Merged

Added missing deprecation notices to Lua docs #21110

merged 1 commit into from Oct 16, 2023

Conversation

penev92
Copy link
Member

@penev92 penev92 commented Oct 11, 2023

Apparently our Lua documentation doesn't include deprecation notices!

PunkPun
PunkPun previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, haven't tried to load to docs

@Mailaender
Copy link
Member

Looks a bit clearer and nicer with my suggestions:

image

@penev92
Copy link
Member Author

penev92 commented Oct 15, 2023

Eh, alright.

@penev92
Copy link
Member Author

penev92 commented Oct 16, 2023

Updated.

@Mailaender Mailaender merged commit 7515c18 into OpenRA:bleed Oct 16, 2023
3 checks passed
@Mailaender
Copy link
Member

5eff728

OpenRA/docs@c27dffa

@Mailaender
Copy link
Member

Changelog

@penev92 penev92 deleted the luaDocsDeprecation branch October 17, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mailaender Mailaender Mailaender approved these changes

@PunkPun PunkPun PunkPun left review comments

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@penev92 @Mailaender @PunkPun