Several minor fixes to ModelWidget #21117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
force-pushed
the
modelWidget
branch
from
04e7975
to
ee14e0e
Compare
RoosterDragon
approved these changes
Oct 12, 2023
PunkPun
reviewed
Oct 13, 2023
| @@ -190,9 +190,6 @@ public override void PrepareRenderables() | |||
| if (cameraAngle != cachedCameraAngle) | |||
| cachedCameraAngle = cameraAngle; | |||
|
|
|||
| if (cachedVoxel == null) | |||
| return; | |||
|
|
|||
There was a problem hiding this comment.
You remove cachedVoxel in the 4th commit. Why is this separated to the first commit?
There was a problem hiding this comment.
I can merge both together if you want, this was just the first change I made on this file, see the commit description. (This condition was always false.)
PunkPun
requested changes
Oct 13, 2023
|
Are you sure that this is wrong? On bleed we didn't use any light calculation at all. This is now using the same as ingame, so the light is coming at an angle. The thing is that the ground the shadow is projected on isn't rotated with the model in the UI. |
|
IMO it's better to keep the original behaviour as it looks way better |
|
Restored the light settings bleed (accidentally) used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits. (I suggest reviewing them in isolation.) There were a few unnecessary checks and unused variables. Caching values which don't need any calculations does not make any sense if they are immediately overwritten on change anyway. Light pitch and yaw were also ignored previously.