Several minor fixes to ModelWidget#21117
Conversation
abcdefg30
force-pushed
the
modelWidget
branch
from
04e7975 to
ee14e0e
Compare
|
|
||
| if (cachedVoxel == null) | ||
| return; | ||
|
|
There was a problem hiding this comment.
You remove cachedVoxel in the 4th commit. Why is this separated to the first commit?
There was a problem hiding this comment.
I can merge both together if you want, this was just the first change I made on this file, see the commit description. (This condition was always false.)
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
The PR seems to have glitched shadows in the asset browser
In this PR
PR.mov
On bleed
Bleed.mov
|
Are you sure that this is wrong? On bleed we didn't use any light calculation at all. This is now using the same as ingame, so the light is coming at an angle. The thing is that the ground the shadow is projected on isn't rotated with the model in the UI. |
|
IMO it's better to keep the original behaviour as it looks way better |
|
Restored the light settings bleed (accidentally) used. |
3 participants
See commits. (I suggest reviewing them in isolation.) There were a few unnecessary checks and unused variables. Caching values which don't need any calculations does not make any sense if they are immediately overwritten on change anyway. Light pitch and yaw were also ignored previously.