Allow actors to target terrain without force-fire #21124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obrakmann
force-pushed
the
terrain-targeting
branch
from
e0eca7d
to
516b9ff
Compare
PunkPun
reviewed
Oct 21, 2023
| @@ -55,6 +55,10 @@ public abstract class AttackBaseInfo : PausableConditionalTraitInfo | |||
| [Desc("Tolerance for attack angle. Range [0, 512], 512 covers 360 degrees.")] | |||
| public readonly WAngle FacingTolerance = new(512); | |||
|
|
|||
| [Desc("Show the target cursor even on empty terrain cells when enabled.", | |||
| "Any traits implementing IMove must be absent or disabled for this to work.")] | |||
| public readonly bool TargetsTerrain = false; | |||
There was a problem hiding this comment.
Suggested change
| public readonly bool TargetsTerrain = false; | |
| public readonly bool TargetsTerrain = false; |
We were discussing on discord that this needs a rename. It's almost sounds as if by having it false the unit won't be able to target terrain at all
Personally I don't have suggestions, sorry
There was a problem hiding this comment.
Changed to TargetTerrainWithoutForceFire. Any better?
obrakmann
force-pushed
the
terrain-targeting
branch
from
516b9ff
to
535f178
Compare
obrakmann
force-pushed
the
terrain-targeting
branch
from
535f178
to
7ccbee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small addition to
AttackBase. It should be useful for things like mortars, artillery or ballistic missiles.