Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DetectCloaked: actor should be in world #21128

Merged
merged 1 commit into from Oct 17, 2023
Merged

DetectCloaked: actor should be in world #21128

merged 1 commit into from Oct 17, 2023

Conversation

dnqbob
Copy link
Contributor

@dnqbob dnqbob commented Oct 17, 2023

Otherwise, detecting unit will leave the detection circle at where it gets on the transport.

abcdefg30
abcdefg30 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but lgtm.

PunkPun
PunkPun approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APC with a riflemen no longer detects phase transport

@PunkPun PunkPun merged commit c427e24 into OpenRA:bleed Oct 17, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Oct 17, 2023

Changelog

@dnqbob dnqbob deleted the detectionfix branch October 17, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcdefg30 abcdefg30 abcdefg30 approved these changes

@PunkPun PunkPun PunkPun approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnqbob @PunkPun @abcdefg30