Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy OpenGL support. #21143

Merged
merged 1 commit into from Oct 22, 2023
Merged

Remove legacy OpenGL support. #21143

merged 1 commit into from Oct 22, 2023

Conversation

pchote
Copy link
Member

@pchote pchote commented Oct 22, 2023

With #21142 and its future followups adding many new shaders, support for the legacy GLSL version is becoming increasingly awkward to maintain.

The sysinfo database (downloaded before release-20231010 was released) showed that only 29 out of the 45302 sysinfo entries (0.06%) on release-20230225 were using this fallback, so this feels like a good time to make the jump.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-10-22 at 19 44 26

Doesn't the OpenGL profile option need to be removed?

@pchote
Copy link
Member Author

pchote commented Oct 22, 2023

No, that is still used for switching between GL/GLES/ANGLE.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'll gladly take this PR

@PunkPun PunkPun merged commit 9a5f5f9 into OpenRA:bleed Oct 22, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Oct 22, 2023

Changelog

@pchote pchote deleted the remove-legacy-gl branch October 29, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants