Remove legacy OpenGL support.#21143
Merged
Merged
Conversation
pchote
force-pushed
the
remove-legacy-gl
branch
from
9f57a92 to
8301e2f
Compare
PunkPun
reviewed
Oct 22, 2023
Member
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
Doesn't the OpenGL profile option need to be removed?
Member
Author
|
No, that is still used for switching between GL/GLES/ANGLE. |
PunkPun
approved these changes
Oct 22, 2023
Member
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
Then I'll gladly take this PR
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #21142 and its future followups adding many new shaders, support for the legacy GLSL version is becoming increasingly awkward to maintain.
The sysinfo database (downloaded before
release-20231010was released) showed that only 29 out of the 45302 sysinfo entries (0.06%) onrelease-20230225were using this fallback, so this feels like a good time to make the jump.