Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shader type conversion. #21149

Merged
merged 1 commit into from Oct 24, 2023
Merged

Fix shader type conversion. #21149

merged 1 commit into from Oct 24, 2023

Conversation

pchote
Copy link
Member

@pchote pchote commented Oct 23, 2023

Regression from #21146.

@dnqbob

This comment was marked as off-topic.

Sign in to view
@pchote
Copy link
Member Author

pchote commented Oct 24, 2023

That is a different, unrelated, issue.

@dnqbob
Copy link
Contributor

dnqbob commented Oct 24, 2023

I will make a separated issue, then.

PunkPun
PunkPun approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been reported to have fixed the issue and I haven't noticed any regressions

@PunkPun PunkPun merged commit f1fba1e into OpenRA:bleed Oct 24, 2023
3 checks passed
@dnqbob dnqbob mentioned this pull request Oct 24, 2023
Closed
@PunkPun
Copy link
Member

PunkPun commented Oct 24, 2023

Changelog

@pchote pchote deleted the shader-fix branch October 29, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PunkPun PunkPun PunkPun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pchote @dnqbob @PunkPun