ImportGen2Map: Fix imports of malformed maps Fixes #21126#21150
Merged
Conversation
abcdefg30
reviewed
Oct 29, 2023
tinix0
force-pushed
the
fix-ts-map-import
branch
2 times, most recently
from
a0e095c to
971a081
Compare
PunkPun
reviewed
Nov 4, 2023
Member
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
Overall LGTM, but I'd just really like the unprojection logic to be reused. Could it be extracted into a function inside Map?
tinix0
force-pushed
the
fix-ts-map-import
branch
from
971a081 to
caf2905
Compare
tinix0
force-pushed
the
fix-ts-map-import
branch
from
caf2905 to
dd61423
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21126
Some of the maps in the bug have unmarked comments before the first section in the map INI file, so we need to skip everything beforehand.
Other maps have invalid bottom bounds. The importer checks if we can correctly unproject the bottom bound, and if not, we reduce it, until it is valid.