Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a collection of mission browser layout issues #21169

Merged
merged 1 commit into from Oct 29, 2023
Merged

Fix a collection of mission browser layout issues #21169

merged 1 commit into from Oct 29, 2023

Conversation

pchote
Copy link
Member

@pchote pchote commented Oct 29, 2023

  • incorrect tab dimensions
  • incorrect margins
  • incorrect alignment between briefing video bin and mission list / details
  • tooltip vs dropdown interaction
  • missing title translation

@pchote pchote mentioned this pull request Oct 29, 2023
Closed
PunkPun
PunkPun approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit dd95b19 into OpenRA:bleed Oct 29, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Oct 29, 2023

Changelog

@pchote pchote deleted the missionbrowser-fixes branch October 29, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PunkPun PunkPun PunkPun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pchote @PunkPun