Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set of buildings of AtreidesSmall2Base in harkonnen09a.lua #21177

Merged
merged 1 commit into from Nov 4, 2023
Merged

Fix set of buildings of AtreidesSmall2Base in harkonnen09a.lua #21177

merged 1 commit into from Nov 4, 2023

Conversation

oldnaari
Copy link
Contributor

Fix wrong Windtrap considered a part of AtreidesSmall2Base in Harkonnen mission 09a

Here are the relevant segments from map.yaml

OpenRA/mods/d2k/maps/harkonnen-09a/map.yaml

Lines 865 to 867 in 917b051

APower21: wind_trap
Location: 38,67
Owner: Atreides Small Base 1

OpenRA/mods/d2k/maps/harkonnen-09a/map.yaml

Lines 604 to 606 in 917b051

APower22: wind_trap
Location: 25,30
Owner: Atreides Small Base 2

OpenRA/mods/d2k/maps/harkonnen-09a/map.yaml

Lines 634 to 636 in 917b051

APower23: wind_trap
Location: 19,33
Owner: Atreides Small Base 2

@oldnaari oldnaari changed the title Update harkonnen09a.lua Fix set of buildings of AtreidesSmall2Base in harkonnen09a.lua Oct 30, 2023
JovialFeline
JovialFeline reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@JovialFeline JovialFeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the correction. I looked through the map because I lacked context. I came away with two suggestions.

mods/d2k/maps/harkonnen-09a/harkonnen09a.lua Outdated Show resolved Hide resolved
mods/d2k/maps/harkonnen-09a/harkonnen09a.lua Outdated Show resolved Hide resolved
oldnaari
oldnaari commented Oct 31, 2023
View reviewed changes
Copy link
Contributor Author

@oldnaari oldnaari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right. Missed those for some reason

@abcdefg30
Copy link
Member

Can you squash the commits together, please?

@oldnaari @JovialFeline
Fix buildings assigned ro wrong bases in harkonnen09a.lua
b15d789 
Update harkonnen09a.lua
Apply suggestions from code review

Co-Authored-By: JovialFeline <jms.happycat@gmail.com>
@oldnaari
Copy link
Contributor Author

Done 👍

@abcdefg30 abcdefg30 merged commit 01fec1a into OpenRA:bleed Nov 4, 2023
3 checks passed
@abcdefg30
Copy link
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JovialFeline JovialFeline JovialFeline left review comments

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oldnaari @abcdefg30 @JovialFeline