Fix set of buildings of AtreidesSmall2Base in harkonnen09a.lua#21177
Merged
abcdefg30 merged 1 commit intoOpenRA:bleedfrom Nov 4, 2023
Merged
Fix set of buildings of AtreidesSmall2Base in harkonnen09a.lua#21177abcdefg30 merged 1 commit intoOpenRA:bleedfrom
abcdefg30 merged 1 commit intoOpenRA:bleedfrom
Conversation
oldnaari
changed the title
Contributor
JovialFeline
left a comment
JovialFeline
left a comment
There was a problem hiding this comment.
Thank you for the correction. I looked through the map because I lacked context. I came away with two suggestions.
oldnaari
commented
Oct 31, 2023
Contributor
Author
oldnaari
left a comment
oldnaari
left a comment
There was a problem hiding this comment.
You are absolutely right. Missed those for some reason
Member
|
Can you squash the commits together, please? |
Update harkonnen09a.lua Apply suggestions from code review Co-Authored-By: JovialFeline <jms.happycat@gmail.com>
Contributor
Author
|
Done 👍 |
abcdefg30
approved these changes
Nov 4, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix wrong Windtrap considered a part of AtreidesSmall2Base in Harkonnen mission 09a
Here are the relevant segments from
map.yamlOpenRA/mods/d2k/maps/harkonnen-09a/map.yaml
Lines 865 to 867 in 917b051
OpenRA/mods/d2k/maps/harkonnen-09a/map.yaml
Lines 604 to 606 in 917b051
OpenRA/mods/d2k/maps/harkonnen-09a/map.yaml
Lines 634 to 636 in 917b051