New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow WeatherOverlay fade in/out when enabled/disabled #21182
Conversation
OpenRA.Mods.Common/Scripting/Global/WorldActorConditionGlobal.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One fixup, otherwise LGTM.
public readonly int FadeInTicks = 1000; | ||
|
||
[Desc("Percentage of the initial particle when enabled and the game start.")] | ||
public readonly int InitialParticlePercentage = 100; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels a bit speculatively general IMO. Do we have a realistic usecase for needing a value that isn't 100 when it starts enabled and 0 when it starts disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option is used for when player want to start from mid-stage of the weather, any weather. For example, a map starts from mid-stage of a thundershower: there is only mid rain but get heavier as time goes by, when it at max stage there will be lightning and thunder by using FlashPostProcessEffect
(we can make it conditional and scriptable later).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to have this option
public readonly int FadeInTicks = 1000; | ||
|
||
[Desc("Percentage of the initial particle when enabled and the game start.")] | ||
public readonly int InitialParticlePercentage = 100; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to have this option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.