Use spans to improve performance in StreamExts.#21186
Merged
PunkPun merged 1 commit intoOpenRA:bleedfrom Nov 10, 2023
Merged
Conversation
anvilvapre
approved these changes
Nov 5, 2023
PunkPun
reviewed
Nov 8, 2023
RoosterDragon
force-pushed
the
stream-spans
branch
from
80a5874 to
987193b
Compare
Member
Author
|
Added some missing newlines. |
abcdefg30
reviewed
Nov 8, 2023
Also avoid ReadBytes calls that allocate a buffer by either updating the stream position (if not interested in the bytes), by reusing an input buffer (if interested in the bytes), or using a stackalloc buffer to avoid the allocation (for small reads).
RoosterDragon
force-pushed
the
stream-spans
branch
from
987193b to
0d79d21
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also avoid ReadBytes calls that allocate a buffer by either updating the stream position (if not interested in the bytes), by reusing an input buffer (if interested in the bytes), or using a stackalloc buffer to avoid the allocation (for small reads).
This isn't motivated by any specific performance benchmark, but rather just on the basis that moving towards using more span features in something that affects a large chunk of the codebase such as streams will provide some incremental gains.