New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify and polish D2k effects/palettes. #21210
Conversation
d836035
to
a1c4598
Compare
Code changes look fine, but this needs to be scrutinized in game. 馃 |
a1c4598
to
f613c5b
Compare
Updated to restore the previous fog visuals, and added a new commit to use the correct trike icon (4305 is a duplicate of 4277 in DATA.R8, but garbage in DATA.R16). |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually shouldn't there be an update rule for the trait removal?
They are d2k-specific traits in the Mods.D2k.dll, so IMO no (and this would cause problems with visibility since |
But in update we only deal in strings. We don't use actual classes that could have dependency issues unless it's basic structs such as CPos. And we do write update rules for Mods.Cnc.dll |
Added update rules. |
needs a rebase |
997dd4c
to
ee069b8
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR does some initial housekeeping around D2k palettes in preparation for using the R16 sprites (aka D2kHDR 馃寛).
I compared most of our effects against the "Dune 2000 Map and Mission Editor" tool which caught some discrepencies that I have now also fixed.
The cloak palette will be handled in its own PR.
The fog now looks slightly different, i'm hoping this won't be too controversial.