Style fixes (.NET 8 SDK) #21211
Merged
Style fixes (.NET 8 SDK) #21211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But needs a rebase already. |
…omatically This is creating some false warnings, so disable for now.
RoosterDragon
force-pushed
the
style-fixes
branch
from
11ebf3e
to
72cd1c6
Compare
|
Rebased. |
PunkPun
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're using the .NET 8 SDK that came out today (or e.g. updated Visual Studio which ships it) then some of the style rules have been updated and trigger additional warnings locally. We can also except them to be flagged by CI once the runners move to .NET 8, even if we continue to specify .NET 6 as the build target.
Fix these issues to improve the local dev experience for anybody using this SDK: