Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new code style rules (.NET 8) #21216

Merged
merged 6 commits into from Nov 16, 2023
Merged

Conversation

RoosterDragon
Copy link
Member

Add new code style rules from .NET 8. We don't enforce them yet since we support a .NET 6 target, but we can still get them into the config and fix them up. Also take the chance to fix violations for some .NET 7 rules, again without enforcing the rule as yet. (See #21011)

.editorconfig Outdated Show resolved Hide resolved
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, untested

Copy link
Member

@penev92 penev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, partially tested

@penev92 penev92 merged commit c8efc5f into OpenRA:bleed Nov 16, 2023
3 checks passed
@penev92
Copy link
Member

penev92 commented Nov 16, 2023

Changelog

@RoosterDragon RoosterDragon deleted the style-net8 branch November 16, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants