Skip to content

Add new code style rules (.NET 8)#21216

Merged
penev92 merged 6 commits into
OpenRA:bleedfrom
RoosterDragon:style-net8
Nov 16, 2023
Merged

Add new code style rules (.NET 8)#21216
penev92 merged 6 commits into
OpenRA:bleedfrom
RoosterDragon:style-net8

Conversation

@RoosterDragon

Copy link
Copy Markdown
Member

Add new code style rules from .NET 8. We don't enforce them yet since we support a .NET 6 target, but we can still get them into the config and fix them up. Also take the chance to fix violations for some .NET 7 rules, again without enforcing the rule as yet. (See #21011)

Comment thread .editorconfig Outdated

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, untested

@penev92 penev92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, partially tested

@penev92 penev92 merged commit c8efc5f into OpenRA:bleed Nov 16, 2023
@penev92

penev92 commented Nov 16, 2023

Copy link
Copy Markdown
Member

Changelog

@RoosterDragon RoosterDragon deleted the style-net8 branch November 16, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants