Fix D2k objectives, alerts in Ha2, Or4, At5#21245
Merged
Merged
Conversation
Contributor
|
all mission tested. LGTM |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes to objectives or alerts that seemed worthwhile, if a bit light for separate PRs.
Harkonnen 2a & 2b
The only player objective is now a primary one, so victory will actually trigger.
Ordos 4
To avoid warnings about flying debris (which are almost guaranteed from nearby walls), the Outpost to be captured will now check if attackers are alive and owned by the player.
The editor pointed out a (harmless) name mismatch, so I threw in a correction for that.
Atreides 5
Like the Ordos 4 Outpost, the Starport now only gives a warning when attacked by the player, just in case the nearby Wind Traps are blown apart first.
Text for finishing the Harkonnen has been fixed.