Store ICrushable traits as actor field.

[anvilvapre]

Store ICrushable traits as actor field.

To avoid using calls to trait dictionary TraitsImplementing that will cause the actor to be looked up in a list of all actors - with the ICrushable trait - using a binary search.

Relevant as path planning uses it to determine if a cell is blocked.

The down side is that actor needs to be ICrushable aware. This requires the move of ICrushable from Common to OpenRA.Traits.

Alternative could be to only introduce an abstract IActorIsBlockingCheck trait that could be cast to an ICrushable. But that seems less clean. Or to let trait dictionary store certain traits that are looked up mostly by actor as a hash table.

[PunkPun]

related #14920

[RoosterDragon]

We already have so many traits against actor for pathfinding perf, I think moving Crushable out of Common is acceptable to enable this last one.

[PunkPun]

We should really create a dumbed down version of actor that actor inherits

[PunkPun]

something that tree's for example could be. They for example don't need activities nor order handling

We already have so many traits against actor for pathfinding perf

could you list them?

[RoosterDragon]

OpenRA/OpenRA.Game/Actor.cs

Lines 164 to 183 in 9a1823d

	// PERF: Cache all these traits as soon as the actor is created. This is a fairly cheap one-off cost per
	// actor that allows us to provide some fast implementations of commonly used methods that are relied on by
	// performance-sensitive parts of the core game engine, such as pathfinding, visibility and rendering.
	// Note: The blocks are required to limit the scope of the t's, so we make an exception to our normal style
	// rules for spacing in order to keep these assignments compact and readable.
	{ if (trait is IOccupySpace t) OccupiesSpace = t; }
	{ if (trait is IEffectiveOwner t) EffectiveOwner = t; }
	{ if (trait is IFacing t) facing = t; }
	{ if (trait is IHealth t) health = t; }
	{ if (trait is IResolveOrder t) resolveOrdersList.Add(t); }
	{ if (trait is IRenderModifier t) renderModifiersList.Add(t); }
	{ if (trait is IRender t) rendersList.Add(t); }
	{ if (trait is IMouseBounds t) mouseBoundsList.Add(t); }
	{ if (trait is IVisibilityModifier t) visibilityModifiersList.Add(t); }
	{ if (trait is IDefaultVisibility t) defaultVisibility = t; }
	{ if (trait is INotifyBecomingIdle t) becomingIdlesList.Add(t); }
	{ if (trait is INotifyIdle t) tickIdlesList.Add(t); }
	{ if (trait is ITargetable t) targetablesList.Add(t); }
	{ if (trait is ITargetablePositions t) targetablePositionsList.Add(t); }
	{ if (trait is ISync t) syncHashesList.Add(new SyncHash(t)); }

[PunkPun]

Changelog