Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique beacon and join/leave/change sounds in lobby #21265

Merged
merged 2 commits into from Mar 12, 2024

Conversation

Porenutak
Copy link
Contributor

Sound file MULTI1.WAV is not used anywhere and there for can be used as becon sound instead of CHAT1.WAV

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it seems I forgot to leave a comment here.

I dunno when and if #6246 is going to get implemented, but it would be good to think about the sounds d2k should use. It would not be great if this sound overlapped with join / leave

@Porenutak
Copy link
Contributor Author

I dunno when and if #6246 is going to get implemented, but it would be good to think about the sounds d2k should use. It would not be great if this sound overlapped with join / leave

@pchote suggested on discord that it should be added in separate PR. But I need to by this PR merged first, because I wanna use new beacon sound also for joining/leaving

@PunkPun
Copy link
Member

PunkPun commented Mar 3, 2024

my entire point that these things should have unique sounds. I think beacon and join/leave matching sounds would be confusing to say the liest

@Porenutak
Copy link
Contributor Author

As you suggested here:
#6246 (comment)

I would like to go
For Join lobby: CHAT1.WAV

CHAT1.ZIP

For leaving lobby: CHAT1.WAV but reversed (Can ORA reverse sound?)
CHAT1_REVERSE.zip

and for chat it self ENDLIST1.WAV or SIDEBAR1.WAV
or just stay with CHAT1.WAV

ENDLIST1.ZIP
SIDEBAR1.ZIP

@Porenutak
Copy link
Contributor Author

Added lobby sounds:
Join: CHAT1.WAV
Leave: CHAT1REVERSE.WAV
Options: SIDEBAR1.WAV

Know issue:
Because of Default variant in notification definition I cannot use nameming convention in bits folder for CHAT1REVERSE

@Porenutak Porenutak changed the title Add unique beacon sound for D2k mod Add unique beacon and join/leave/change sounds in lobby Mar 12, 2024
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit d4457a4 into OpenRA:bleed Mar 12, 2024
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Mar 12, 2024

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants