New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unique beacon and join/leave/change sounds in lobby #21265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it seems I forgot to leave a comment here.
I dunno when and if #6246 is going to get implemented, but it would be good to think about the sounds d2k should use. It would not be great if this sound overlapped with join / leave
@pchote suggested on discord that it should be added in separate PR. But I need to by this PR merged first, because I wanna use new beacon sound also for joining/leaving |
my entire point that these things should have unique sounds. I think beacon and join/leave matching sounds would be confusing to say the liest |
As you suggested here: I would like to go For leaving lobby: CHAT1.WAV but reversed (Can ORA reverse sound?) and for chat it self ENDLIST1.WAV or SIDEBAR1.WAV |
Added lobby sounds: Know issue: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sound file MULTI1.WAV is not used anywhere and there for can be used as becon sound instead of CHAT1.WAV