Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trike muzzle sequence #21267

Merged
merged 1 commit into from Dec 20, 2023
Merged

Conversation

Porenutak
Copy link
Contributor

@Porenutak Porenutak commented Dec 19, 2023

While digging in #21266 I realize that trike use wrong muzzle sequence compared to OG.

2023-12-19.14-27-04.mp4

PunkPun
PunkPun previously approved these changes Dec 19, 2023
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun
Copy link
Member

PunkPun commented Dec 20, 2023

Needs a rebase.

Trike

I'm also not sure if this looks correct. Muzzle feels too far from the gun

@Porenutak
Copy link
Contributor Author

Rebased. Muzzle offset fixed

@PunkPun
Copy link
Member

PunkPun commented Dec 20, 2023

They look identical

Trikes

@Porenutak
Copy link
Contributor Author

that was the point. Wasnt it?

2023-12-20.12-16-17.mp4

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@PunkPun PunkPun merged commit a0b1bdd into OpenRA:bleed Dec 20, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Dec 20, 2023

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants