Skip to content

Add support for custom smudge smoke offset and add flame spawns to RA/TD - continued#21272

Merged
PunkPun merged 3 commits into
OpenRA:bleedfrom
CDVoidwalker:smudge-offset
Jan 6, 2024
Merged

Add support for custom smudge smoke offset and add flame spawns to RA/TD - continued#21272
PunkPun merged 3 commits into
OpenRA:bleedfrom
CDVoidwalker:smudge-offset

Conversation

@CDVoidwalker

Copy link
Copy Markdown
Contributor

Supersedes #19238

Tested on both mods, seems to work fine, lowered flamer smudge chance by a lot as multiple projectiles cluttered the effect.

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the commits be squashed in a way that makes sense?

Comment thread OpenRA.Mods.Common/Traits/World/SmudgeLayer.cs Outdated
Comment thread OpenRA.Mods.Common/Traits/World/SmudgeLayer.cs Outdated

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@PunkPun PunkPun merged commit e96865b into OpenRA:bleed Jan 6, 2024
@PunkPun

PunkPun commented Jan 6, 2024

Copy link
Copy Markdown
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants