Fix Hovers desync caused by changing 'WorldVisualOffset' in renderer. #21298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Under testing, I also need your testing result on ensuring the fix. Please set the frame option like below during testing: |
PunkPun
approved these changes
Jan 12, 2024
|
Why is this marked as draft? |
|
Because it was under testing. We hardly fully test the PRs merged recently and flaws and crash like this will happen in unexpected ways. |
|
it was tested, but it's hard to catch everything, especially bugs hidden in barely related areas. I thought I did consider desyncs, no idea how I didn't catch the error |
|
I think it should be the problem of frame setting. Limited frame will make this problem hard to expose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21297