Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uses of LabelWidget.Text and ButtonWidget.Text to use GetText instead. #21300

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix uses of LabelWidget.Text and ButtonWidget.Text to use GetText instead. #21300

merged 1 commit into from
Jan 15, 2024

Commits on Jan 13, 2024

  1. Fix uses of LabelWidget.Text and ButtonWidget.Text to use GetText ins… 

    …tead.

The Text element of these widgets was changed from display text to a translation key as part of adding translation support. Functions interested in the display text need to invoke GetText instead. Lots of functions have not been updated, resulting in symptoms such as measuring the font size of the translation key rather than the display text and resizing a widget to the wrong size.

Update all callers to use GetText when getting or setting display text. This ensure their existing functionality that was intended to work in terms of the display text and not the translation key works as expected.
    @RoosterDragon
    RoosterDragon committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    cbcdf22 View commit details
    Browse the repository at this point in the history