Use HashSets instead of .Distinct#21311
Merged
Merged
Conversation
RoosterDragon
left a comment
RoosterDragon
left a comment
Member
There was a problem hiding this comment.
As Distinct() preserves the original ordering, in a few cases I think it'd be safer to stick with that just in case rather than switching to a set which won't preserve the order.
And don't cast to array / list where unnecessary
RoosterDragon
approved these changes
Jan 27, 2024
atlimit8
approved these changes
Jan 31, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the correct data type should require less cycles. Also removed a few unnecessary casts to array / list