Skip to content

Editor: add Resource counter and measurement info into Area Selection tab#21315

Merged
PunkPun merged 1 commit into
OpenRA:bleedfrom
Porenutak:Info-from-selection
Feb 3, 2024
Merged

Editor: add Resource counter and measurement info into Area Selection tab#21315
PunkPun merged 1 commit into
OpenRA:bleedfrom
Porenutak:Info-from-selection

Conversation

@Porenutak
Copy link
Copy Markdown
Contributor

@Porenutak Porenutak commented Jan 25, 2024

Supersedes #20175
Closes: #18222

d2k-2024-01-24T161913831Z

Know issue:
Resource counter dont work on shell map.

@MustaphaTR
Copy link
Copy Markdown
Member

MustaphaTR commented Jan 25, 2024

Resource counter dont work on shell map.

That's because resources have no value on the shellmaps, so the silos won't fill, causing the harvesters/miners to stop at some point. I would say it is WAI. Tho i guess Refineries could be edited to use UseStorage: false or DiscardExcessResources: true instead to achive the same thing without breaking this.

Edit: ShowTicks: false as well.

Copy link
Copy Markdown
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, just needs some minor polish

Comment thread OpenRA.Mods.Common/Widgets/Logic/Editor/MapEditorSelectionLogic.cs
Comment thread mods/common/chrome/editor.yaml Outdated
Comment thread OpenRA.Mods.Common/Widgets/Logic/Editor/MapEditorSelectionLogic.cs
Comment thread mods/cnc/languages/chrome/en.ftl Outdated
Comment thread OpenRA.Mods.Common/Traits/World/EditorResourceLayer.cs Outdated
Comment thread mods/cnc/chrome/editor.yaml Outdated
@Porenutak Porenutak force-pushed the Info-from-selection branch 5 times, most recently from 68e2dd7 to 45b892c Compare January 31, 2024 10:03
Selection info into Area selection tab

add Resource counter and measure info into Area selection tab
@Porenutak Porenutak force-pushed the Info-from-selection branch from 45b892c to 316f48c Compare January 31, 2024 15:29
@PunkPun PunkPun merged commit 4e031a6 into OpenRA:bleed Feb 3, 2024
@PunkPun
Copy link
Copy Markdown
Member

PunkPun commented Feb 3, 2024

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map Editor - Distance Measure tool

3 participants