Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: add Resource counter and measurement info into Area Selection tab #21315

Merged
merged 1 commit into from Feb 3, 2024

Conversation

Porenutak
Copy link
Contributor

@Porenutak Porenutak commented Jan 25, 2024

Supersedes #20175
Closes: #18222

d2k-2024-01-24T161913831Z

Know issue:
Resource counter dont work on shell map.

@MustaphaTR
Copy link
Member

MustaphaTR commented Jan 25, 2024

Resource counter dont work on shell map.

That's because resources have no value on the shellmaps, so the silos won't fill, causing the harvesters/miners to stop at some point. I would say it is WAI. Tho i guess Refineries could be edited to use UseStorage: false or DiscardExcessResources: true instead to achive the same thing without breaking this.

Edit: ShowTicks: false as well.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, just needs some minor polish

mods/common/chrome/editor.yaml Outdated Show resolved Hide resolved
mods/cnc/languages/chrome/en.ftl Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/World/EditorResourceLayer.cs Outdated Show resolved Hide resolved
mods/cnc/chrome/editor.yaml Outdated Show resolved Hide resolved
Selection info into Area selection tab

add Resource counter and measure info into Area selection tab
@PunkPun PunkPun merged commit 4e031a6 into OpenRA:bleed Feb 3, 2024
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Feb 3, 2024

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map Editor - Distance Measure tool
3 participants