Fix editor area/actor deselection bugs

[drogoganor]

There are two state issues with selection and deselection in the editor after the new changes.

• After dragging out an area selection, right clicking to deselect the area leaves the area selection panel visible.
• If you drag out an area selection, then click an actor, then click cancel, the area selection panel is still shown.

This PR fixes these issues. ActorEditLogic needed some logic to fire in a handler for DefaultBrush.SelectionChanged instead of Tick().

Also added a missing copyright header.

Also fixes #21314

[Porenutak]

a bit off topic, but it would be intuitive if selected area can be canceled also with Escape key. Same for Copy/paste brush

[PunkPun]

undo does not seem to remove actor selection visual

[PunkPun]

the history tab seems a bit bugged. If you go to a select action then you are put into the selection panel, instead of being able to move through the rest on history. I dunno what the best way to fix that is.

And also all subsequent actions are deleted as the "Cleared Selection" action is added (or is going back to history tab inserting the action?)

[drogoganor]

I'll check out that History tab bug. Sorry Pun I thought it was in better shape.
EDIT: That history tab issue is fixed in the most recent commit now.

There's a couple of other code design issues I still want to address too:

• The ActorEditLogic has a CurrentActor property. I think this should actually come from the EditorDefaultBrush.Selection.Actor now.
• Additionally, there's a Selected property on the EditorActorPreview. I'm wondering if this flag should be set to true/false in the EditorDefaultBrush now instead.

[PunkPun]

yeah, probably they should be controlled by the default brush

[drogoganor]

I'll continue working on this but just letting you know I'm happy if you want to back out the editor selection PR until it's fully ready to go.

[drogoganor]

I did the intended code refactor items I mentioned in a previous comment:

• Remove SelectedActorProperty from ActorEditLogic (source from Selection.Actor from EditorDefaultBrush instead)
• Set the EditorActorPreview.Selected property to true/false in the new EditorDefaultBrush.Selection setter instead.

I also applied your idea to invoke the SelectionChanged event from the EditorDefaultBrush.Selection setter instead, which is tidier and worked as intended.

Two annoyances still remain:

• Clicking a selection changed event in the History tab changes the tab to the (not shown) selection tab - as you mentioned, we could simply make the selection tab a visible tab instead. We have the room for it now. The tab could be disabled when there's nothing selected.
• When you delete a selected actor, it inserts two history events: unselect the actor, then delete it. It would be good if these were merged into one.

[drogoganor]

Select tab button has been (re)introduced. It's disabled if there's no current selection.

Added fixes for the last two items mentioned:

• Clicking selection changed items in the history tab will no longer change to the Select tab. (Though this does produce an annoying issue - if you select an actor/area on the map with the history tab open, it won't go to the Select tab. Could be fixed with a parameter on the SelectionChanged event that determines whether the change was from undo/redo or from user action - however, the event is invoked from within the EditorDefaultBrush.Selection setter, so it will need some extra thought).
• Deleting a selected actor will now only produce one history item instead of two.

Also reintroduced a fix for issue #21314 as per PunkPun's suggested code change.

I also added a couple of little fixes for the new area selection info panel (I might look at that in more detail later).

I also made the chrome for the editor icon collection use a distinct set instead of reusing the timer and infantry icons as suggested in Discord by Dzierzan:

editor:
    Inherits: ^Glyphs
    Regions:
        tiles: 35, 171, 16, 16
        overlays: 52, 171, 16, 16
        tools: 69, 171, 16, 16
        actors: 100, 171, 16, 16
        history: 130, 171, 16, 16

Having a ResourceLayer defined should be optional again as per michael.dgg.2's suggestion.

ArtSrc changes are here: OpenRA/ArtSrc#20

[PunkPun]

it looks like icons became off-centred

when I select a resource, it blinks on the last spot where the add resource cursor was rendered. Same with tiles. I wonder if this is a recent regression.

I wonder how other cursors should work. Now when you change cursors you nolonger delete selection. The actor is still selected, and the area select still exists (you can copy paste), but just not rendered while another cursor is equipped. I feel like changing cursor should delete selection.

Perhaps the select tab should act as a button that sets cursor to the default cursor? That way it would still have a function while there's no selection available and would not need to be disabled

[drogoganor]

Thanks for the code review again Pun. I agree, changing cursors should clear the selection - I added a ClearSelection(); to the EditorDefaultBrush.Dispose() which does that.

I tested out the "flashing tile" issue on commit b58c1ea (before the selection changes) - it happens there, too. I guess it needs a tick to set the cursor position again.
Reproduction steps:

• Select a tile brush, and hover it somewhere
• Right-click to deselect the brush
• Select an actor brush
• Select a tile brush again

The select tab being enabled without a selection is a possibility - we could add an instructions label to the empty tab, to the effect of "Left-click to select an actor, or left-click and drag to select an area.". I guess the downside is that the tiles aren't shown as soon as you create a new map (likely the first thing the user will want to use).

Yes, it's a real pain that the icons seem off-center, too. I wonder if they can be offset in the chrome? The problem is that the buttons are 49 pixels wide.
EDIT: I'm an idiot - they have positions that are explicitly set! I will fix that.
EDIT: Button icons are centered again now.

The area selection info panel needs a bit of work to fit correctly on the minimum supported resolution (1280x720 I believe), but I should probably leave that for another PR. I think the "Area Selection" header could have the dimensions and coordinate range instead, like "Area Selection: 13,47 - 25,55 (12x8)"
(Screenshot includes centered buttons)

[drogoganor]

I also made some adjustments to the area selection panel info area so it will fit at 1280x720. The area and dimensions are now shown in the title:

I also correctly centered the title label.

[drogoganor]

I've altered the area select behavior now so that the selection is kept when selecting a different brush. I know this is contrary to my earlier comment, but after playing around with it, I think it's better behavior.

Right clicking will not clear the selection. This matches actor selection behavior.
Right clicking an actor or overlay with an area selection will delete the actor or overlay.
Switching to the selection tab with another brush selected will no longer show a blank panel.

Undo/redo actions will no longer switch tabs. This required a change to IEditorAction.Do() to pass a isUndoRedoAction bool (Should this be named "isHistoryAction" instead?)

I'm much happier with how it all fits together now.

[PunkPun]

if you copy-paste with no filters on, the undo action won't undo the removed actors

[drogoganor]

I reverted the change to the IEditorAction interface and introduced a separate event EditorDefaultBrush.UpdateSelectedTab, instead.
I also fixed the actor copy/paste not being gated by the filter correctly, ack.

[PunkPun]

LGTM

[PunkPun]

changelog