Hovers: remove dependency on IMove trait#21338
Merged
Merged
Conversation
Mailaender
previously approved these changes
Feb 12, 2024
atlimit8
previously approved these changes
Feb 13, 2024
atlimit8
left a comment
atlimit8
left a comment
Member
There was a problem hiding this comment.
It just needs the test commit removed for merging. It is unlikely that any real uses will also use WithBuildingBib.
michaeldgg2
dismissed stale reviews from atlimit8 and Mailaender
via
8260aa8
michaeldgg2
force-pushed
the
hovers-no-imove
branch
from
43d9d92 to
8260aa8
Compare
atlimit8
approved these changes
Feb 13, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was requested on Discord (so the
Hoverstrait could be used on a building).Hoverstrait does not useIMove(Info), so the dependency is unnecessary.