Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovers: remove dependency on IMove trait #21338

Merged
merged 1 commit into from Feb 13, 2024

Conversation

michaeldgg2
Copy link
Contributor

This change was requested on Discord (so the Hovers trait could be used on a building).

Hovers trait does not use IMove(Info), so the dependency is unnecessary.

openra_hovers_no_imoveinfo

Mailaender
Mailaender previously approved these changes Feb 12, 2024
atlimit8
atlimit8 previously approved these changes Feb 13, 2024
Copy link
Member

@atlimit8 atlimit8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just needs the test commit removed for merging. It is unlikely that any real uses will also use WithBuildingBib.

@atlimit8 atlimit8 merged commit 9d29303 into OpenRA:bleed Feb 13, 2024
3 checks passed
@atlimit8
Copy link
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants