Fix missing map files preventing map saves #21345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoosterDragon
approved these changes
Mar 9, 2024
anvilvapre
approved these changes
Mar 25, 2024
| { | ||
| var stream = Package.GetStream(filename); | ||
| if (stream == null || !Enumerable.SequenceEqual(data, stream.ReadAllBytes())) | ||
| toPackage.Update(filename, data); |
There was a problem hiding this comment.
Might as well compare two Spans? (Or even just always update?)
https://stackoverflow.com/questions/43289/comparing-two-byte-arrays-in-net
There was a problem hiding this comment.
We don't want to always update as to avoid changing the file edit date, see #20630. When it comes to spans wouldn't this be too much data?
There was a problem hiding this comment.
Enumerable.SequenceEqual will drop to comparing spans internally if it is possible. So I'd keep this as-is for readability.
abcdefg30
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #20630. Currently you are forced to have to have a preview for a map in order to generate a new preview
Reported by Therapist on discord
The git diff looks atrocious for what is a very simple change 馃槢