Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch actors directly in DropPodsPower. #21359

Merged
merged 1 commit into from Mar 9, 2024
Merged

Fetch actors directly in DropPodsPower. #21359

merged 1 commit into from Mar 9, 2024

Conversation

RoosterDragon
Copy link
Member

Use direct dictionary lookups, rather than iterating the entire actors dictionary.

@RoosterDragon
Fetch actors directly in DropPodsPower.
fecb8f9 
Use direct dictionary lookups, rather than iterating the entire actors dictionary.
PunkPun
PunkPun approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really cold code, but it doesn't hurt to have it a bit more efficient

@PunkPun PunkPun merged commit 00a23e6 into OpenRA:bleed Mar 9, 2024
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Mar 9, 2024

changelog

@RoosterDragon RoosterDragon deleted the droppods branch March 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PunkPun PunkPun PunkPun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RoosterDragon @PunkPun