Skip to content

Fix ActorIndex when dealing with multiple trait instances.#21371

Merged
PunkPun merged 1 commit into
OpenRA:bleedfrom
RoosterDragon:fix-actor-index
Mar 16, 2024
Merged

Fix ActorIndex when dealing with multiple trait instances.#21371
PunkPun merged 1 commit into
OpenRA:bleedfrom
RoosterDragon:fix-actor-index

Conversation

@RoosterDragon
Copy link
Copy Markdown
Member

The intended check was "has any trait", but TraitOrDefault throws if there is more than one. Adjust this check so it doesn't throw in the face of multiple trait instances.

Resolves a regression introduced in #21360.

The intended check was "has any trait", but TraitOrDefault throws if there is more than one. Adjust this check so it doesn't throw in the face of multiple trait instances.

Resolves a regression introduced in 63de527.
Copy link
Copy Markdown
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit c18d10c into OpenRA:bleed Mar 16, 2024
@PunkPun
Copy link
Copy Markdown
Member

PunkPun commented Mar 16, 2024

changelog

@RoosterDragon RoosterDragon deleted the fix-actor-index branch March 17, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants