Skip to content

Minelayer: remove unnecessary requirement on Rearmable#21380

Merged
PunkPun merged 1 commit into
OpenRA:bleedfrom
michaeldgg2:minelayer-remove-rearmable
Apr 3, 2024
Merged

Minelayer: remove unnecessary requirement on Rearmable#21380
PunkPun merged 1 commit into
OpenRA:bleedfrom
michaeldgg2:minelayer-remove-rearmable

Conversation

@michaeldgg2
Copy link
Copy Markdown
Contributor

Minelayer requires Rearmable, but Minelayer does not use it. LayMines activity uses Rearmable, but it can work without it:

if ((minefield == null || minefield.Contains(self.Location)) && CanLayMine(self, self.Location))
{
    if (rearmableInfo != null && ammoPools.Any(p => p.Info.Name == minelayer.Info.AmmoPoolName && !p.HasAmmo))
    {
    // ...

This PR simply removes the mandatory dependency on Rearmable, making it possible to remove Rearmable trait on actors, which don't need to use it.

@PunkPun PunkPun merged commit ed5c7bb into OpenRA:bleed Apr 3, 2024
@PunkPun
Copy link
Copy Markdown
Member

PunkPun commented Apr 3, 2024

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants