Trim memory usage of various collections. #21383
Merged
+41
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvilvapre
approved these changes
Apr 1, 2024
PunkPun
reviewed
Apr 3, 2024
These implementations are often backed by a Dictionary, and tend to live a long time after being loaded. Ensure TrimExcess is called on the backing dictionaries to reduce the long term memory usage. In some cases, we can also preallocate the dictionary size for efficiency.
As the SpriteCache is used as a one-shot operation in practise, holding on to the capacity of backing collections is not required. Memory usage can be reduced by allowing the capacity to be reset after the SpriteCache has resolved items. - Once LoadReservations is called, reset the reservation dictionaries so their backing collections can be reclaimed. - When ResolveSprites is called, shrink the resolved dictionary as resolutions take place.
When LoadFromManifest is called, trim the various backing collections. These backing collections tend to live a long time without further modifications.
For indexed PNGs, we only need to allocate a palette large enough to accommodate the number of indexed colours in the image. For images that don't use all 256 colours, this slightly reduces the memory usage for these images.
RoosterDragon
force-pushed
the
trim-collections
branch
from
1c6bb4a
to
abe5048
Compare
I took a more precise measurement, 0.3mb for the RA mod, 0.35mb for tdhd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes target a series of classes that load data into a Dictionary/List/Array and then live a long time without modifying the backing collection after that. We can realize some memory savings by shrinking the capacity of the backing collections so that they are not holding onto unused capacity longer than required.
Collectively this saves about 0.3 megabyte of memory, which isn't a lot, but the changes are quite simple.