Extract strings from resource renderer#21386
Merged
Merged
Conversation
Member
RoosterDragon
left a comment
There was a problem hiding this comment.
Change looks good to me.
This is failing because #21389 now complains it doesn't know how to lint it due to the LoadUsing. I'd be fine hacking in a custom check just like we have for GameSpeeds.
OpenRA/OpenRA.Mods.Common/Lint/CheckTranslationReference.cs
Lines 131 to 137 in 10d7436
30b3b80 to
4cc240f
Compare
RoosterDragon
approved these changes
Apr 27, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes #10475