Map chooser polish & refactoring #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes issues relating to RunAfterTick calls being run out of order - the downside being that the list remains empty until the iteration is complete. This will be fixed in a following patch.
|
Indeed that looks and works better now from the user perspective. |
This really should be fixed generally in ScrollPanelWidget, but this is the most painful case.
|
👍 |
Mailaender
added a commit
that referenced
this pull request
Apr 6, 2013
Map chooser polish & refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add some much needed polish to the map chooser in C&C, and removes some of the issues associated with the map chooser logic.
The map list is now generated synchronously, but the previews generation is async within the MapPreviewWidget.