Fix chat synchronization in replays. #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be a nice nit fix for casters I imagine. Cool deal if all works well! |
| while( replayStream.Position < replayStream.Length ) | ||
| public void Receive(Action<int, byte[]> packetFn) | ||
| { | ||
| while (sync.Count != 0) |
There was a problem hiding this comment.
sync.Any() should terminate earlier → better performance.
There was a problem hiding this comment.
sync is a list, so it should give roughly identical performance.
There was a problem hiding this comment.
This is old code that I haven't changed, and List.Count just returns an internal size member anyway so there is no perf difference.
This probably wants to be using a queue instead of faking one with a list, so I may change this anyway.
|
👍 also does not break #4233 in a test merge. |
|
Needs a rebase. |
|
Rebased. |
Mailaender
added a commit
that referenced
this pull request
Mar 8, 2014
Fix chat synchronization in replays.
|
This introduced a severe regression that I did not see because I never tested a network game #4866. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.