Port nod03b to New Lua #6328
Merged
Port nod03b to New Lua #6328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
👍 |
|
That civilian shouldn't be gdi, should it? |
obrakmann
force-pushed
the
nod03b
branch
2 times, most recently
from
16d2fcb
to
b520637
Compare
|
updated |
|
👍 |
|
Before this is merged: GDI seems to stop building infantry (or never builds any) pretty early on and consequently stops attacking after the first two or three attacks, is that intentional? If not, I retract my 👍 until that is fixed. |
|
Correct, there isn't any production happening on this map (in nod03a neither). I didn't touch any of the logic but just did a straight 1:1 port of it, so that would be expected. I agree that GDI should use its barracks eventually, though. |
|
I noticed that most of these new ports (merged and un-merged) don't play the "Mission Accomplished" notification once you win. This should be addressed in a followup issue. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.