Update to MaxMind GeoIP2 .NET version 2.1.0 #6902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
geoip-2.1.0
branch
from
a8211fc
to
ecc7e44
Compare
Mailaender
changed the title
|
I've confirmed that this at least compiles and runs, but there isn't any easy way to test the functionality locally. We will need to organize a dev game so that we can check a few location lookups in the lobby. |
|
Just go to the game server list. You may need to tweak your version string or enable a debug settings which ignores incompatible versions. |
|
The incompatible checkbox replaces the country label with the mod + version string. Editing the mod.yaml to set |
|
👍 |
obrakmann
added a commit
that referenced
this pull request
Nov 11, 2014
Update to MaxMind GeoIP2 .NET version 2.1.0
|
https://github.com/OpenRA/OpenRA/blob/bleed/OpenRA.Game/Settings.cs#L74 was the developer setting I was talking about. It is not exposed to the GUI. I was asked to remove it for polishing reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a pre-release version before. I also updated the http://dev.maxmind.com/geoip/geoip2/geolite2/ database.