Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported Survival01 to Lua #6934

Merged
merged 7 commits into from Nov 23, 2014
Merged

Ported Survival01 to Lua #6934

merged 7 commits into from Nov 23, 2014

Conversation

abcdefg30
Copy link
Member

There are three difficulties available, you can switch between them here ingame.

Still some open points, should...

  • I add map.png from the allied missions?
  • you be able to build medis and spys from barracks (without tent) as well?
  • the soviets repair their buidlings?
  • come additional paratroopers and naval transports?
  • the new secondary objectives stay?

Pinging @NukemBro , who created this minigame mission.

Mailaender
Mailaender reviewed Nov 13, 2014
View reviewed changes
mods/ra/maps/Survival01/map.yaml

UseAsShellmap: False

Type: Minigame
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a mini game. We just lacked a single-player selection menu at that time.

@abcdefg30
Copy link
Member Author

Updated. I added an allies03a-style description. Hope it's ok so.

Mailaender
Mailaender reviewed Nov 15, 2014
View reviewed changes
mods/ra/maps/Survival01/survival01.lua
@@ -0,0 +1,329 @@
Difficulty = "Medium"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map.Difficulty will expose this according to https://github.com/OpenRA/OpenRA/wiki/Lua-API. You will still need to create some GUI so that players can actually access it.

@abcdefg30 abcdefg30 force-pushed the survival01 branch 4 times, most recently from 689e487 to 72ab978 Compare November 18, 2014 20:52
@abcdefg30
Copy link
Member Author

Updated and added support for selecting mission difficulty.
Updated "Intervention" as well.

@abcdefg30 abcdefg30 force-pushed the survival01 branch 2 times, most recently from 896783b to 111537c Compare November 19, 2014 12:46
@abcdefg30
Copy link
Member Author

Updated again.

@abcdefg30 abcdefg30 force-pushed the survival01 branch 3 times, most recently from dc919b9 to 42cc9d4 Compare November 19, 2014 17:55
@obrakmann
Copy link
Contributor

Just played a round on this. First attempt was on the default skill (Hard), was brutally murdered within a minute...

Second try on Easy was better, got to hold out until the end and won, but it got pretty close at times. I'll try again tomorrow and see if it gets easier then.

I'll also take a look at the code tomorrow.

Thanks for the Intervention fix, and yay \o/ for the difficulty selector!

obrakmann
obrakmann reviewed Nov 20, 2014
View reviewed changes
mods/ra/maps/Survival01/map.yaml

RequiresMod: ra

Title: Survivial01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Survival 01" for readability?

Edit: And please make the folder name lower-case for consistency.

@Mailaender Mailaender changed the title Ported Survival01 to lua Ported Survival01 to Lua Nov 20, 2014
obrakmann
obrakmann reviewed Nov 20, 2014
View reviewed changes
mods/ra/maps/Survival01/survival01.lua
end)
end)

Trigger.OnAllKilled(SovietBuildings, function()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This becomes a problem when you decide to capture some enemy buildings instead of destroying them. You end up having to kill your own buildings.

@abcdefg30
Copy link
Member Author

Updated.
As I'm running out of time today,
I'll test, balance the rewards and fix the (unfortunately marked as outdated) comments tomorrow.

obrakmann
obrakmann reviewed Nov 20, 2014
View reviewed changes
mods/ra/maps/Survival01/survival01.lua
allies.MarkFailedObjective(DestroyObj)
else
allies.MarkFailedObjective(SurviveObj)
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just let the Wookie soviets win, that will cause the remaining allied objectives to be marked as failed automatically.

@obrakmann
Copy link
Contributor

you need using OpenRA.Traits when you use Requires

@abcdefg30
Copy link
Member Author

Updated.

Mailaender
Mailaender reviewed Nov 22, 2014
View reviewed changes
mods/ra/maps/survival01/map.yaml

RequiresMod: ra

Title: Survival01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Survival 01 with a space looks more in line with the official campaigns.

@abcdefg30
Copy link
Member Author

Updated again.

@Mailaender
Copy link
Member

👍

@Mailaender Mailaender mentioned this pull request Nov 22, 2014
Closed
2 tasks
@obrakmann
Copy link
Contributor

regarding the open questions:

  1. I'd say medis and spies shouldn't be buildable from barracks, although my only reasoning is that it's consistent with our regular rules.
  2. Yes, keep the secondary objectives. They do serve a purpose now and completing them gives an actual benefit.

👍 from me too, then. Could you please remove the remaining comments from the source files? I'll merge once that's done.

@abcdefg30 abcdefg30 force-pushed the survival01 branch 2 times, most recently from 3eb256e to 6e1593b Compare November 22, 2014 20:05
@abcdefg30
Copy link
Member Author

Updated.

@abcdefg30
Copy link
Member Author

Updated.

Mailaender added a commit that referenced this pull request Nov 23, 2014
@Mailaender
Merge pull request #6934 from abcdefg30/survival01
f263579 
Ported Survival01 to Lua
@Mailaender Mailaender merged commit f263579 into OpenRA:bleed Nov 23, 2014
@Mailaender
Copy link
Member

Well done!

@Mailaender
Copy link
Member

Changelog

@Mailaender
Copy link
Member

Lua API changes

@abcdefg30 abcdefg30 deleted the survival01 branch November 23, 2014 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abcdefg30 @obrakmann @Mailaender