Moved more traits to Mods.Common #7570
Conversation
Mailaender
force-pushed
the
mods-common
branch
2 times, most recently
from
5ca401e
to
ebcc8f8
Compare
| @@ -67,8 +67,6 @@ Chrome: | |||
| Assemblies: | |||
| ./mods/common/OpenRA.Mods.Common.dll | |||
| ./mods/ra/OpenRA.Mods.RA.dll | |||
| ./mods/cnc/OpenRA.Mods.Cnc.dll | |||
There was a problem hiding this comment.
This will break the custom RA maps that port the Ion Cannon and other TD things into RA.
There was a problem hiding this comment.
There are quite a few on the resource center, unfortunately.
There was a problem hiding this comment.
So keep that DLL or move the Ion Cannon to Mods.Common?
There was a problem hiding this comment.
My preference would be to keep the DLL for now, and then later replace the overly specific Ion Cannon and Nuke support powers with a more general "Fire an armament" power in mods.common (with their special missile / beam behaviour implemented as projectiles).
|
Looks ok to me, didn't notice any regression in-game. 👍 Needs a rebase. |
|
Rebased. |
| namespace OpenRA.Mods.RA.Scripting | ||
| { | ||
| [ScriptPropertyGroup("Paradrop")] | ||
| public class ParadropPowers : ScriptActorProperties, Requires<CargoInfo>, Requires<ParaDropInfo> |
There was a problem hiding this comment.
I'm not familiar with how the Lua API works, but shouldn't this be called ParadropProperties ?
Either that or the file name needs to be changed.
There was a problem hiding this comment.
I agree with penev here, please rename for consistency, and then let's get this merged.
There was a problem hiding this comment.
Sorry. Forgot about this one. Updated.
|
Looks good and noticed no issues on RA and TD shellmaps. 👍 |
Moved more traits to Mods.Common
Tried to see how far I could come regarding #7526.