Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update widget mouseover when scrolling panels. #8055

Merged
merged 1 commit into from Apr 29, 2015

Conversation

pchote
Copy link
Member

@pchote pchote commented Apr 28, 2015

The new map editor remains blocked by #8017, so here's another chunk that can be reviewed in parallel.

This fixes a long-standing bug where scrolling a scrollpanel does not update the mouseover region beneath it. A simple repro/fix case is to mouse-over a game in the server browser, and then scroll the panel with the mousewheel. The highlighted game will now correctly change.

@pchote pchote mentioned this pull request Apr 28, 2015
4 tasks
@Mailaender
Copy link
Member

I solved this differently Mailaender@1f1fee0 in #4496.

@pchote
Copy link
Member Author

pchote commented Apr 28, 2015

Indeed, but that only solves about 1/4 of the problem: there are two places where the scrolling occurs, and that doesn't handle mouse entry for the newly moused over widget.

@obrakmann
Copy link
Contributor

This works as promised, 👍

@Mailaender
Copy link
Member

I can't see tooltips in the server browser and believe we never had some. However the faction tooltips seem to work better in the lobby when scrolling. ✅ I had some trouble with tooltips not appearing in the lobby maybe upon leave and restart, but I am not sure if this is introduced by this or maybe just a performance flaw.

@pchote
Copy link
Member Author

pchote commented Apr 29, 2015

@Mailaender: this isn't about tooltips, but hover / mouseovers in general.

@pchote
Copy link
Member Author

pchote commented Apr 29, 2015

Rebased to try and force a refresh of appveyor and nuget (feels more like crappveyor and noget lately :s).

@Mailaender
Copy link
Member

Well. You did not change any .csproj files and nothing here is covered by unit tests so I am fine with Travis CI being green.

@Mailaender
Copy link
Member

Scrolling indeed works much better for long lists. It now updates the high-lighted reason not just at the end of the scroll when moving the mouse again.

Mailaender added a commit that referenced this pull request Apr 29, 2015
Update widget mouseover when scrolling panels.
@Mailaender Mailaender merged commit b1dd380 into OpenRA:bleed Apr 29, 2015
@Mailaender
Copy link
Member

Changelog

@pchote pchote deleted the scroll-mouseover branch May 17, 2015 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants