New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update widget mouseover when scrolling panels. #8055
Conversation
I solved this differently Mailaender@1f1fee0 in #4496. |
Indeed, but that only solves about 1/4 of the problem: there are two places where the scrolling occurs, and that doesn't handle mouse entry for the newly moused over widget. |
This works as promised, 👍 |
I can't see tooltips in the server browser and believe we never had some. However the faction tooltips seem to work better in the lobby when scrolling. ✅ I had some trouble with tooltips not appearing in the lobby maybe upon leave and restart, but I am not sure if this is introduced by this or maybe just a performance flaw. |
@Mailaender: this isn't about tooltips, but hover / mouseovers in general. |
07b6cd2
to
cd12dcc
Compare
Rebased to try and force a refresh of appveyor and nuget (feels more like crappveyor and noget lately :s). |
Well. You did not change any .csproj files and nothing here is covered by unit tests so I am fine with Travis CI being green. |
Scrolling indeed works much better for long lists. It now updates the high-lighted reason not just at the end of the scroll when moving the mouse again. |
Update widget mouseover when scrolling panels.
The new map editor remains blocked by #8017, so here's another chunk that can be reviewed in parallel.
This fixes a long-standing bug where scrolling a scrollpanel does not update the mouseover region beneath it. A simple repro/fix case is to mouse-over a game in the server browser, and then scroll the panel with the mousewheel. The highlighted game will now correctly change.